Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter/aws-lambda): remove unneeded import and compatibility for LLRT #3915

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Feb 12, 2025

this pr fixes #3914

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (8340a7b) to head (4fd4811).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3915      +/-   ##
==========================================
+ Coverage   91.28%   91.30%   +0.02%     
==========================================
  Files         168      168              
  Lines       10757    10662      -95     
  Branches     3166     3162       -4     
==========================================
- Hits         9819     9735      -84     
+ Misses        937      926      -11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdamAme-x EdamAme-x marked this pull request as draft February 12, 2025 02:21
@watany-dev
Copy link
Contributor

watany-dev commented Feb 12, 2025

The only reason node:crypto is declared in the Lambda@edge Adaptor is because it was declared in the AWS Lambda Adaptor at the time of creation.

By the way, the runtime of Lambda@Edge is fixed to Python or Node.js, so there may be no need to delete it. Because
Not related to #3914

@EdamAme-x
Copy link
Contributor Author

Close this once.

@EdamAme-x EdamAme-x closed this Feb 12, 2025
@EdamAme-x EdamAme-x reopened this Feb 12, 2025
@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Feb 12, 2025

@watany-dev I changed the approach.
Users can use compatible code from hono/aws-lambda/llrt.

@EdamAme-x EdamAme-x changed the title fix(lambda-edge): remove unused node:crypto feat(lambda-edge): Compatibility for LLRT Feb 12, 2025
@EdamAme-x EdamAme-x changed the title feat(lambda-edge): Compatibility for LLRT feat(aws-lambda): Compatibility for LLRT Feb 12, 2025
@EdamAme-x EdamAme-x changed the title feat(aws-lambda): Compatibility for LLRT fix(aws-lambda): remove unneeded import and compatibility for LLRT Feb 12, 2025
@EdamAme-x EdamAme-x changed the title fix(aws-lambda): remove unneeded import and compatibility for LLRT fix(adapter/aws-lambda): remove unneeded import and compatibility for LLRT Feb 12, 2025
@EdamAme-x
Copy link
Contributor Author

ref: #3914 (comment)

@EdamAme-x EdamAme-x marked this pull request as ready for review February 12, 2025 12:09
@usualoma
Copy link
Member

I think this is a reasonable change.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@EdamAme-x

Thank you! I think this is ready to merge. Let's go.

@yusukebe yusukebe merged commit 9892b47 into honojs:main Feb 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of "node:crypto" in aws-lambda (LLRT runtime)
4 participants