-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(adapter/aws-lambda): remove unneeded import and compatibility for LLRT #3915
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3915 +/- ##
==========================================
+ Coverage 91.28% 91.30% +0.02%
==========================================
Files 168 168
Lines 10757 10662 -95
Branches 3166 3162 -4
==========================================
- Hits 9819 9735 -84
+ Misses 937 926 -11
Partials 1 1 ☔ View full report in Codecov by Sentry. |
The only reason By the way, the runtime of Lambda@Edge is fixed to Python or Node.js, so there may be no need to delete it. Because |
Close this once. |
@watany-dev I changed the approach. |
node:crypto
This reverts commit e80ce9b.
ref: #3914 (comment) |
I think this is a reasonable change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! I think this is ready to merge. Let's go. |
this pr fixes #3914
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code